Skip to content

HADOOP-17760. Delete hadoop.ssl.enabled and dfs.https.enable from docs and core-default.xml#3099

Merged
tasanuma merged 2 commits intoapache:trunkfrom
tasanuma:HADOOP-17760
Jun 17, 2021
Merged

HADOOP-17760. Delete hadoop.ssl.enabled and dfs.https.enable from docs and core-default.xml#3099
tasanuma merged 2 commits intoapache:trunkfrom
tasanuma:HADOOP-17760

Conversation

@tasanuma
Copy link
Member

@tasanuma tasanuma commented Jun 11, 2021

JIRA: HADOOP-17760

@hadoop-yetus
Copy link

hadoop-yetus commented Jun 11, 2021

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 54s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 31m 28s trunk passed
+1 💚 compile 20m 55s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 18m 9s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 1m 7s trunk passed
+1 💚 mvnsite 1m 36s trunk passed
+1 💚 javadoc 1m 8s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 45s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 2m 26s trunk passed
+1 💚 shadedclient 15m 58s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 55s the patch passed
+1 💚 compile 20m 19s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 20m 19s the patch passed
+1 💚 compile 18m 9s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 18m 9s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 4s the patch passed
+1 💚 mvnsite 1m 37s the patch passed
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 7s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 43s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 2m 34s the patch passed
+1 💚 shadedclient 15m 46s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 1s hadoop-common in the patch passed.
+1 💚 asflicense 0m 58s The patch does not generate ASF License warnings.
177m 11s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3099/1/artifact/out/Dockerfile
GITHUB PR #3099
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml markdownlint spotbugs checkstyle
uname Linux eb7d73c8db4b 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 73924d0
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3099/1/testReport/
Max. process+thread count 2158 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3099/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

ayushtkn
ayushtkn reviewed Jun 16, 2021
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx @tasanuma
Seems the conf has a mention in this file as well twice:
https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-sls/src/main/data/2jobs2min-rumen-jh.json#L4562

See, if we can remove it from there as well

@tasanuma
Copy link
Member Author

tasanuma commented Jun 16, 2021

Thanks for your review, @ayushtkn. Updated the PR.

ayushtkn
ayushtkn approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx @tasanuma
+1, if the build has no complains

@hadoop-yetus
Copy link

hadoop-yetus commented Jun 16, 2021

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 markdownlint 0m 1s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 10s Maven dependency ordering for branch
+1 💚 mvninstall 20m 13s trunk passed
+1 💚 compile 20m 48s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 18m 4s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 3m 50s trunk passed
+1 💚 mvnsite 2m 24s trunk passed
+1 💚 javadoc 1m 51s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 2m 25s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 26s trunk passed
+1 💚 shadedclient 14m 23s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for patch
+1 💚 mvninstall 1m 20s the patch passed
+1 💚 compile 20m 8s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 20m 8s the patch passed
+1 💚 compile 18m 7s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 18m 7s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 3m 48s the patch passed
+1 💚 mvnsite 2m 22s the patch passed
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 50s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 2m 24s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 49s the patch passed
+1 💚 shadedclient 14m 44s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 16m 55s hadoop-common in the patch passed.
+1 💚 unit 12m 17s hadoop-sls in the patch passed.
+1 💚 asflicense 0m 58s The patch does not generate ASF License warnings.
205m 16s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3099/2/artifact/out/Dockerfile
GITHUB PR #3099
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml markdownlint spotbugs checkstyle
uname Linux 624fa50c3b2e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 0385063
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3099/2/testReport/
Max. process+thread count 2231 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-sls U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3099/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tasanuma tasanuma merged commit 9e7c7ad into apache:trunk Jun 17, 2021
@tasanuma
Copy link
Member Author

tasanuma commented Jun 17, 2021

Merged. Thanks for reviewing it, @ayushtkn!

@tasanuma tasanuma deleted the HADOOP-17760 branch June 17, 2021 00:59
tasanuma added a commit that referenced this pull request Jun 17, 2021
@tasanuma
HADOOP-17760. Delete hadoop.ssl.enabled and dfs.https.enable from doc…
25138c9 
…s and core-default.xml (#3099)

Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 9e7c7ad)
tasanuma added a commit that referenced this pull request Jun 17, 2021
@tasanuma
HADOOP-17760. Delete hadoop.ssl.enabled and dfs.https.enable from doc…
2f29784 
…s and core-default.xml (#3099)

Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 9e7c7ad)
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@tasanuma
HADOOP-17760. Delete hadoop.ssl.enabled and dfs.https.enable from doc…
36a4699 
…s and core-default.xml (apache#3099)

Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tasanuma @hadoop-yetus @ayushtkn